Test some visual effects on MathML content #24935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwlbuis
force-pushed
the
mathml_visual_effects
branch
from
b2654bd
to
8c38fe7
Compare
|
LGTM, I wonder if some of these things might cause flaky failure due to antialiasing and similar... Maybe use translation instead of or rotation with angle multiple of 90° ; and a path with horizontal/vertical edges instead of a circle? Not sure if that's needed, and I don't really have any suggestion for blur... |
Good point about antialiasing, I'll try to prevent that before landing. |
rwlbuis
force-pushed
the
mathml_visual_effects
branch
from
8c38fe7
to
4ecbcfb
Compare
rwlbuis
force-pushed
the
mathml_visual_effects
branch
from
4ecbcfb
to
81b9b6f
Compare
rwlbuis
force-pushed
the
mathml_visual_effects
branch
from
81b9b6f
to
472935b
Compare
rwlbuis
force-pushed
the
mathml_visual_effects
branch
from
472935b
to
1237a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/mathml-refresh/mathml/issues/179.