Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neomutt: 20200626 -> 20200814 #95095

Merged
merged 2 commits into from Aug 16, 2020
Merged

neomutt: 20200626 -> 20200814 #95095

merged 2 commits into from Aug 16, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 10, 2020 •
edited

Motivation for this change

⚠️ Caution: 20200807 is only a development release and not considered stable, so please don't merge! I already had to apply a patch to fix a segfault on startup.

This is only intended to be used by power-users who want to try out the latest version. I don't consider this mergable until the 20.09 branchoff happened, after that we can discuss how to proceed with this.

ChangeLog: https://github.com/neomutt/neomutt/releases/tag/20200807, https://github.com/neomutt/neomutt/releases/tag/20200814

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member Author

Ma27 commented Aug 11, 2020

@GrahamcOfBorg eval

@Ma27 Ma27 marked this pull request as ready for review August 14, 2020 20:51
@Ma27
Copy link
Member Author

Ma27 commented Aug 14, 2020

Today's release is marked as stable again and thus we could merge this PR now. Already using the new neomutt version on my machine :)

@Ma27
Copy link
Member Author

Ma27 commented Aug 15, 2020

cc @flokli who also might want to take a look :)

@Ma27 Ma27 changed the title neomutt: 20200626 -> 20200807 neomutt: 20200626 -> 20200814 Aug 15, 2020
flokli
flokli requested changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick glance, LGTM otherwise.

pkgs/applications/networking/mailreaders/neomutt/default.nix Outdated Show resolved Hide resolved
@alyssais
Copy link
Member

@GrahamcOfBorg build neomutt

@flokli flokli merged commit 6d83d29 into NixOS:master Aug 16, 2020
@Ma27 Ma27 deleted the bump-neomutt branch August 16, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli requested changes

@erikryb erikryb Awaiting requested review from erikryb

@vrthra vrthra Awaiting requested review from vrthra

@cstrahan cstrahan Awaiting requested review from cstrahan

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @alyssais @flokli