From a previous glance at the announcement, we're still passing two --enable-obsolete-* flags that should be gone now. That also means those parts will be gone, but hopefully noone has been using them anymore.

Thanks for pointing this out, you're absolutely right! In fact, I already removed obsolete sunrpc patches that aren't needed anymore because of one of those flags being removed 👍

@vcunat btw, can you add a new Hydra jobset for this, please? :)

Created, for now only x86_64.

Nice, thanks! :)

Btw git (https://hydra.nixos.org/build/125038989) builds locally for me.

From a previous glance at the announcement, we're still passing two --enable-obsolete-* flags that should be gone now. That also means those parts will be gone, but hopefully noone has been using them anymore.

Well, unfortunately there are some packages using those. Some packages can be fixed by simply adding libtirpc (and for rpcgen we can use rpcsvc-proto which I packaged on this branch), however there are some packages that don't work with this and need fixed like this:

mkDerivation {
  /* ... */
  
  NIX_CFLAGS_COMPILE = [ "-I${libtirpc.dev}/include/tirpc" ];
  NIX_LDFLAGS = [ "-ltirpc" ];
}

I added a note to the OP to remind myself to mention this in the release-notes.

@vcunat in case you have time to, could you please restart the git-build (https://hydra.nixos.org/build/125051048)? I repeatedly managed to build it locally without any issues.

• succeeded

Have you thought about which NixOS release this would be in? (I haven't looked into how "risky" this PR is.) #95475

Have you thought about which NixOS release this would be in? (I haven't looked into how "risky" this PR is.)

Probably 21.03: there are actually quite many packages using this rpc-stuff from glibc and right now we don't provide a replacement since we don't ship another rpcgen (fixed it on this branch in 2085f65), so downstream pkgs relying on this can't really migrate atm.

Fixed a few more things and rebased onto latest staging-next. Eval for that is running now.

The new breakage is caused by a regression from upstream/staging-next that doesn't seem to be fixed yet:

qtquickcontrols> mkdir: cannot create directory '/nix/store/14kfh0l6627kvvvlg29l8nmjmzp33ipa-qtdeclarative-5.14.2-bin/lib/qt-5.14.2/qml/QtQuick/Controls': Permission denied
qtquickcontrols> make[2]: *** [Makefile:1642: install_qmlcacheinst] Error 1
qtquickcontrols> make[2]: Leaving directory '/build/qtquickcontrols-everywhere-src-5.14.2/src/controls'
qtquickcontrols> make[1]: *** [Makefile:64: sub-controls-install_subtargets] Error 2
qtquickcontrols> make[1]: Leaving directory '/build/qtquickcontrols-everywhere-src-5.14.2/src'
qtquickcontrols> make: *** [Makefile:61: sub-src-install_subtargets] Error 2
qtquickcontrols> builder for '/nix/store/0yb3ds49jb1qzmf14xypdqrkqcx7qxm8-qtquickcontrols-5.14.2.drv' failed with exit code 2

Rebased onto latest staging-next to incorporate the QT fix. Now the ~900 broken packages because of that should be buildable again.

@vcunat great, thanks!

Just rebased onto latest staging, resolved one merge-conflict and marked this as ready to review. Feel free to take a final look and merge if nothing else is missing :)