mkDerivation: use Generic
as system name for Redox in cmakeFlags
#95129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
cmake
does not recognize Redox, but builds still work if the system name "Generic" is used. As far as I know, there are two ways to fix this. I chose the second.cmake
. If accepted, Nixpkgs would eventually need to update to a newcmake
, causing a massive rebuild.cmakeFlags
with the system name. This avoids a big rebuild, and allows the Nix expressions to match the build scripts Redox is currently using to package things.Things done
Use "Generic" as the system name for Redox in cmakeFlags. My understanding is that this shouldn't cause a mass rebuild for anything but Redox.
This change is required for cross-compiling llvm to Redox, which is a dependency needed to build the Redox operating system.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)