New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openjdk11: add src.zip for IDEs #95081
Conversation
the resulting jdk is bigger... by 64M but more usable now for development... it was part of jdk8 but not for 11 |
It's already there in the
We could add an extra symlink (without size increase). But I believe you can also set intellij to use |
Hi, I'm not using Intellij :) plus it's nice when things are in places where the tools look for them (in this case I'm using scala metals) A symlink could work too, I didnt see it in another directory.. although I need to check again to be sure.. |
50e2882
to
714854c
Compare
714854c
to
daadfcf
Compare
@gebner I've updated to use a symlink, thanks :) |
Does metals work out-of-the-box now? Could you also add the symlink to openjdk14, please? |
@gebner yes, it does seem to work fine :) also added to openjdk14, but unable to test if metals works with it as it is limited to java 11 atm. I did check the symlink though and it was resolving. |
Motivation for this change
IDEs use the provided src.zip to navigate the java codebase.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)