Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gxemul: 0.6.0.1 -> 0.6.2 #95094

Merged
merged 1 commit into from Aug 15, 2020
Merged

gxemul: 0.6.0.1 -> 0.6.2 #95094

merged 1 commit into from Aug 15, 2020

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Aug 10, 2020 •
edited

Motivation for this change

Main site seems to be http://gavare.se/gxemul/ instead of the sourceforge one, it has a more recent version and more documentation.

There don't seem to be any maintainers, and I'm personally not interested enough to add myself as one.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@IvarWithoutBones
Copy link
Member Author

Ofborg failure seems to be unrelated to this, as it's complaining about being out of space.

@ryantm
Copy link
Member

ryantm commented Aug 15, 2020

Result of nixpkgs-review pr 95094 1

1 package built:
- gxemul

@ryantm
Copy link
Member

ryantm commented Aug 15, 2020

thanks; please consider adding yourself as a maintainer.

@ryantm ryantm merged commit 8170d62 into NixOS:master Aug 15, 2020
@IvarWithoutBones IvarWithoutBones deleted the gxemul-cleanup branch August 16, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IvarWithoutBones @ryantm