nix-prefetch: make fit for flakes #95137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I did the following
./result/bin/nix-prefetch fetchFromGitHub --owner b4b4r07 --repo enhancd
warning: unknown setting 'experimental-features'
warning: unknown setting 'experimental-features'
The fetcher will be called as follows:
> fetchFromGitHub {
> owner = "b4b4r07";
> repo = "enhancd";
> rev = "f0f894029d12eecdc36c212fa3ad14f55468d1b7";
> sha256 = "0000000000000000000000000000000000000000000000000000";
> }
sha256-y/NZN1lRirO24jDT90ozz65sWgi1Sqp6H5JYOYZyYuI=
I guess the warning is because this expression has the stable nix wrapped while my system is using nixUnstable.
Also doing msteen/nix-prefetch@4b5373e in this expression would alleviate this, wonder what your thoughts are on this.
Adding nixUnstable to the path won't work because command line flags are not compatible with this nix-prefetch. |
Ahh right. |
worldofpeace
approved these changes
Aug 11, 2020
|
Yes! Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)