Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p4: init at 2020.1.1991450 #95103

Merged
merged 1 commit into from Aug 21, 2020
Merged

p4: init at 2020.1.1991450 #95103

merged 1 commit into from Aug 21, 2020

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Aug 10, 2020 •
edited

Motivation for this change

Ad the binary blob perforce command line client.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@corngood corngood mentioned this pull request Aug 20, 2020
Merged
10 tasks
veprbl
veprbl approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@veprbl veprbl merged commit 348051b into NixOS:master Aug 21, 2020
@numinit
Copy link
Contributor

numinit commented Aug 23, 2020

Just a note. I've found that these mirrors are sometimes unstable, at least for versions < 2020.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corngood @numinit @veprbl