Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk11: 11.0.8+10 -> 11.0.8-ga #95123

Closed
wants to merge 1 commit into from
Closed

openjdk11: 11.0.8+10 -> 11.0.8-ga #95123

wants to merge 1 commit into from

Conversation

jerith666
Copy link
Contributor

Motivation for this change

Fixes #95117 ... which I don't really know how to square with #94029 (comment), but it's definitely true.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edwtjo August 11, 2020 03:27
@jerith666
openjdk11: 11.0.8+10 -> 11.0.8-ga
dc3f7f0 
otherwise the build of openjfx 14 fails with a disallowed reference to
jdk 11, somewhat mysteriously.

fixes NixOS#95117
@sir4ur0n
Copy link

Hi, can this PR be reviewed/merged please? I have the same problem for the last few days:

# A LOT of output
stripping (with command strip and flags -S) in /nix/store/7q3hx50k458la5yssrl7mqisg98lpqij-openjfx-modular-sdk-12-14/. 
patching script interpreter paths in /nix/store/7q3hx50k458la5yssrl7mqisg98lpqij-openjfx-modular-sdk-12-14
checking for references to /build/ in /nix/store/7q3hx50k458la5yssrl7mqisg98lpqij-openjfx-modular-sdk-12-14...
output '/nix/store/7q3hx50k458la5yssrl7mqisg98lpqij-openjfx-modular-sdk-12-14' is not allowed to refer to the following paths:
  /nix/store/v2brw3j6nwfq2jzib97n7knr09ckqv2a-openjdk-headless-11.0.8+10
cannot build derivation '/nix/store/74dk6rzwqignfzpb0vrq75dm2lpzapgy-openjdk-12.0.2-ga.drv': 1 dependencies couldn't be built
# blabla

I understand this PR would fix it?

@sir4ur0n
Copy link

What's missing for this to be merged please?

@ghost
Copy link

ghost commented Aug 25, 2020

@asbachb @Ma27 do you have any opinion or alternative solution?

@asbachb
Copy link
Contributor

asbachb commented Aug 25, 2020

I guess I changed it from "-ga" to "+10" since thats the versioning the jdk is normally versioned.
Even when you run java -version you won't get ga, you'll get the build number.

If there's a workaround for having the build number instead of "ga" I'd prefer that.

I don't know what's the exact problem with the derivation.

/CC @edwtjo

@jerith666
Copy link
Contributor Author

I agree it would be nice if we understood this better. But, I'm not sure it needs to hold up the merge either.

I think one next step to understanding it is to see if we can find out how the build against +10 ends up referencing it (since nix doesn't report that to us).

@Ma27
Copy link
Member

Ma27 commented Aug 25, 2020

Currently taking a look at it btw :) Would merge after that unless I find something.

@ghost
Copy link

ghost commented Aug 25, 2020

I figured out the source of the problem: The output path of openjdk11_headless is used in a sed command in pkgs/development/compilers/openjdk/openjfx/14.nix line 99. But the new version contains a '+', which is not escaped and thus interpreted as a regular expression quantifier.

@ghost ghost self-assigned this Aug 25, 2020
@Ma27
Copy link
Member

Ma27 commented Aug 25, 2020

@petabyteboy do you want to fix this here or shall we merge?

@ghost
Copy link

ghost commented Aug 25, 2020

I have a fix that I am testing right now. I think we can close this and I will open another PR with a proper fix in a moment.

@ghost ghost mentioned this pull request Aug 25, 2020
Merged
10 tasks
@ghost ghost closed this Aug 25, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@Ma27 Ma27 Ma27 approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
5 participants
@jerith666 @sir4ur0n @asbachb @Ma27 @bachp