Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypy: 7.1.1 -> 7.3.1 #95127

Merged
merged 2 commits into from Aug 11, 2020
Merged

pypy: 7.1.1 -> 7.3.1 #95127

merged 2 commits into from Aug 11, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Aug 11, 2020

Motivation for this change

Upgrade pypy 7.1.1 to 7.3.1, both normal and prebuilt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
pythonInterpreters.pypy{27,36}_prebuilt: 7.1.1 -> 7.3.1
6f2ec6d 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk
pypy, pypy3: 7.1.1 -> 7.3.1
b31e4a2 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk requested a review from FRidh as a code owner August 11, 2020 02:36
lsix
lsix approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything build fine and I have (shortly) tested pypy3 and everything seems fine.

Since pypy/pypy3 both rely on a common changes having both updates in a single commit (as opposed as one commit for pypy, one for pypy3) makes perfect sense to me and I am perfectly OK with it.

@FRidh FRidh merged commit 52419cc into NixOS:master Aug 11, 2020
@FRidh
Copy link
Member

FRidh commented Aug 11, 2020

Thanks!

@andersk andersk deleted the pypy-7.3.1 branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsix lsix lsix approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersk @FRidh @lsix