Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qcsxcad: init at 0.6.2 #95100

Merged
merged 1 commit into from Aug 11, 2020
Merged

qcsxcad: init at 0.6.2 #95100

merged 1 commit into from Aug 11, 2020

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Aug 10, 2020 •
edited

Motivation for this change

Part of this pr. @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

Also, I don't see the gui being installed:

[nix-shell:/home/jon/.cache/nixpkgs-review/pr-95100]$ tree results/qcsxcad
results/qcsxcad
├── include
│   └── QCSXCAD
│       ├── export_pov.h
│       ├── export_x3d.h
│       ├── QCSGridEditor.h
│       ├── QCSPrimEditor.h
│       ├── QCSPropEditor.h
│       ├── QCSTreeWidget.h
│       ├── QCSXCAD_Global.h
│       ├── QCSXCAD.h
│       ├── QParameterGui.h
│       ├── QVTKStructure.h
│       ├── vtkInteractorStyleRubberBand2DPlane.h
│       └── VTKPrimitives.h
└── lib
    ├── libQCSXCAD.so -> libQCSXCAD.so.0
    ├── libQCSXCAD.so.0 -> libQCSXCAD.so.0.6.2
    └── libQCSXCAD.so.0.6.2

3 directories, 15 files

@matthuszagh
Copy link
Contributor Author

matthuszagh commented Aug 10, 2020 •
edited

@jonringer Are you commenting on the fact that there isn't an application binary among the outputs? QCSXCAD is a library so I believe this is correct. When I run AppCSXCAD (coming up in the next PR) the gui seems to run fine. If I misunderstood your comment, would you mind clarifying?

Also worth mentioning that in addition to your suggested changes, I've updated to revision to be a more recent version.

jonringer
jonringer reviewed Aug 11, 2020
View reviewed changes
pkgs/applications/science/electronics/qcsxcad/default.nix Outdated
enableParallelBuilding = true;

meta = with stdenv.lib; {
description = "Qt-GUI for CSXCAD";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the description says qt-gui for csxcad, but there's no gui, that's what I'm commenting on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this verbatim from the project's description, but I agree it's very misleading. I've changed this to "Qt library for CSXCAD". Better?

jonringer
jonringer approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95100 1

28 packages marked as broken and skipped: - digitalbitbox - glibcCross - linuxPackages_4_4.evdi - linuxPackages_hardkernel_4_14.bcc - linuxPackages_hardkernel_4_14.bpftrace - linuxPackages_hardkernel_4_14.can-isotp - linuxPackages_hardkernel_4_14.digimend - linuxPackages_hardkernel_4_14.evdi - linuxPackages_hardkernel_4_14.mba6x_bl - linuxPackages_hardkernel_4_14.nvidia_x11 - linuxPackages_hardkernel_4_14.r8125 - linuxPackages_hardkernel_4_14.rtl8821au - linuxPackages_hardkernel_4_14.rtl88x2bu - linuxPackages_hardkernel_4_14.rtl88xxau-aircrack - linuxPackages_hardkernel_4_14.rtlwifi_new - newlibCross - php74Extensions.pthreads - python27Packages.caffe - python27Packages.habanero - python27Packages.handout - python27Packages.hass-nabucasa - python27Packages.libmodulemd - python37Packages.nixpart - python37Packages.notify - python38Packages.libselinux - python38Packages.notify - python38Packages.pyblock - qes
1 package built: - qcsxcad

@jonringer jonringer merged commit dad6b63 into NixOS:master Aug 11, 2020
@matthuszagh matthuszagh deleted the qcsxcad branch August 11, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthuszagh @jonringer