Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: Drop PHP 7.2 support #95101

Merged
merged 1 commit into from Aug 10, 2020
Merged

php: Drop PHP 7.2 support #95101

merged 1 commit into from Aug 10, 2020

Conversation

etu
Copy link
Contributor

@etu etu commented Aug 10, 2020

Motivation for this change

PHP 7.2 won't be supported for the entire 20.09 life cycle, so here goes the dropping.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@etu etu requested a review from a team August 10, 2020 17:49
@etu etu added this to the 20.09 milestone Aug 10, 2020
@Ma27
Copy link
Member

Ma27 commented Aug 10, 2020

@etu just realized that there are some (obsolete) references to php72 in aliases.nix. You might want to remove those as well.

@Ma27 Ma27 merged commit 5428974 into NixOS:master Aug 10, 2020
@etu etu deleted the php72-drop-support branch August 11, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz approved these changes

@Ma27 Ma27 Ma27 approved these changes

@dasj19 dasj19 dasj19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@etu @Ma27 @talyz @dasj19