Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nextcloud: add documentation for alternative reverse-proxies #95109

Merged
merged 1 commit into from Aug 16, 2020
Merged

nixos/nextcloud: add documentation for alternative reverse-proxies #95109

merged 1 commit into from Aug 16, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 10, 2020

Motivation for this change

Follow-up for #93584[1]. This change adds a simple example how to use
Nextcloud with httpd.

[1] #93584 (comment)

cc @DavHau

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
nixos/nextcloud: add documentation for alternative reverse-proxies
dd957c2 
Follow-up for NixOS#93584[1]. This change adds a simple example how to use
`Nextcloud` with `httpd`.

[1] NixOS#93584 (comment)
@Ma27 Ma27 requested a review from aanderse August 10, 2020 20:13
@Ma27
Copy link
Member Author

Ma27 commented Aug 10, 2020

Please note that I'm not that experienced with httpd and I basically used the config from the wordpress-module, so feedback very welcome :)

aanderse
aanderse approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. There are a number of ways to do this, but I would expect that the sysadmin should be responsible for figuring out the most appropriate way they want to do it and use this documentation + the nextcloud manual as a starting point.

@aanderse
Copy link
Member

ping @dasj19 as an FYI

@Ma27
Copy link
Member Author

Ma27 commented Aug 11, 2020

@aanderse so from your PoV this is mergeable, we should just wait for a few more folks who were interested in this?

ping @DavHau as original author you also want to take a look at this I guess :)

@aanderse
Copy link
Member

@Ma27 yes, I would merge this now but it's worth waiting a day or two to see if any other interested parties have any comments 👍

@Ma27 Ma27 added this to the 20.09 milestone Aug 16, 2020
@Ma27
Copy link
Member Author

Ma27 commented Aug 16, 2020

@dasj19 @DavHau does this look ok to you?

dasj19
dasj19 approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Ma27 Ma27 merged commit e8bdadb into NixOS:master Aug 16, 2020
@Ma27 Ma27 deleted the nextcloud-reverse-proxy branch August 16, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 dasj19 approved these changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @aanderse @dasj19