Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roundcube: 1.4.7 -> 1.4.8 #95108

Merged
merged 1 commit into from Aug 10, 2020
Merged

roundcube: 1.4.7 -> 1.4.8 #95108

merged 1 commit into from Aug 10, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Aug 10, 2020 •
edited

Motivation for this change

Security fixes.

see https://roundcube.net/news/2020/08/10/security-updates-1.4.8-1.3.15-and-1.2.12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
 asbachb@nixos  ~/dev/src/nix/nixpkgs   update/roundcube  nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
these paths will be fetched (0.03 MiB download, 0.13 MiB unpacked):
  /nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1
copying path '/nix/store/91qp2v2h0fd9d6b6hchzf13zki091grv-nixpkgs-review-2.3.1' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
From https://github.com/NixOS/nixpkgs
   066c604eec6..44d841f758d  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-e513a4e1f9c68337fec67e4931f207a32117092b-dirty/nixpkgs 44d841f758d943636b185f76f6a3f54e5e05a910
Preparing worktree (detached HEAD 44d841f758d)
Updating files: 100% (22399/22399), done.
HEAD is now at 44d841f758d inkcut: init at 2.1.1
$ nix-env -f /home/asbachb/.cache/nixpkgs-review/rev-e513a4e1f9c68337fec67e4931f207a32117092b-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 10, 2020
@Ma27 Ma27 self-requested a review August 10, 2020 21:09
Ma27
Ma27 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed v1.4.8 to my roundcube instance 👍

@Ma27 Ma27 merged commit 7b1b874 into NixOS:master Aug 10, 2020
@Ma27
Copy link
Member

Ma27 commented Aug 10, 2020

Ported to stable as 3a78bb2.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asbachb @Ma27