Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: fec45bdfbcc0
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 830a8d6ee113
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Jul 20, 2020

  1. make-iso9660-image: produce stable GPT disk GUID 

    By generating a version-5 GUID based on $out (which contains
the derivation hash) and preventing isohybrid from overwriting
the GPT table (which already is populated correctly by xorriso).

Tested by:
* booting from USB disk on a UEFI system
* booting from USB disk on a non-UEFI system
* booting from CD on a UEFI system
* booting from CD on a non-UEFI system
* booting from CD on an OSX system

Also tested that "nix-build ./nixos/release-combined.nix -A
nixos.iso_minimal.x86_64-linux -I nixpkgs=~/nixpkgs-r13y --check"
now succeeds.

Fixes #74047
    @raboof
    raboof committed Jul 20, 2020
    Copy the full SHA
    be006ea View commit details
    Browse the repository at this point in the history

  2. Merge pull request #74174 from raboof/fix-74047-stable-gpt-disk-guid 

    make-iso9660-image: produce stable GPT disk GUID
    @timokau
    timokau committed Jul 20, 2020
    Copy the full SHA
    830a8d6 View commit details
    Browse the repository at this point in the history