Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cryptography: 2.9.2 -> 3.0 #93565

Merged
merged 1 commit into from Jul 22, 2020
Merged

python3Packages.cryptography: 2.9.2 -> 3.0 #93565

merged 1 commit into from Jul 22, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Jul 21, 2020 •
edited

Backwards incompatible changes:

  • Removed support for passing an Extension instance to
    from_issuer_subject_key_identifier(), as per our deprecation policy.
  • Support for LibreSSL 2.7.x, 2.8.x, and 2.9.0 has been removed (2.9.1+
    is still supported).
  • Dropped support for macOS 10.9, macOS users must upgrade to 10.10 or
    newer.
  • RSA generate_private_key() no longer accepts public_exponent values
    except 65537 and 3 (the latter for legacy purposes).
  • X.509 certificate parsing now enforces that the version field contains
    a valid value, rather than deferring this check until version is
    accessed.

Deprecations:

  • Deprecated support for Python 2. At the time there is no time table
    for actually dropping support, however we strongly encourage all users
    to upgrade their Python, as Python 2 no longer receives support from
    the Python core team.
Status

Currently running nixpkgs-review.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
python3Packages.cryptography: 2.9.2 -> 3.0
fb3e721 
Backwards incompatible changes:
- Removed support for passing an Extension instance to
  from_issuer_subject_key_identifier(), as per our deprecation policy.
- Support for LibreSSL 2.7.x, 2.8.x, and 2.9.0 has been removed (2.9.1+
  is still supported).
- Dropped support for macOS 10.9, macOS users must upgrade to 10.10 or
  newer.
- RSA generate_private_key() no longer accepts public_exponent values
  except 65537 and 3 (the latter for legacy purposes).
- X.509 certificate parsing now enforces that the version field contains
  a valid value, rather than deferring this check until version is
  accessed.

Deprecations:
- Deprecated support for Python 2. At the time there is no time table
  for actually dropping support, however we strongly encourage all users
  to upgrade their Python, as Python 2 no longer receives support from
  the Python core team.
@primeos
Copy link
Member Author

primeos commented Jul 22, 2020 •
edited

Preliminary results look ok: 2/1633/3741 built (109 failed)

Only one build is failing due to cryptography and was already failing before:

cannot build derivation '/nix/store/hqzk7jcb1lw0m3rwa7lczcidrcr516pv-python3.7-altair-4.1.0.drv': 1 dependencies couldn't be built
builder for '/nix/store/y2sxsx0d523z746yi9ralxc6s238n38y-python3.7-hass-nabucasa-0.34.6.drv' failed with exit code 1; last 10 log lines:
  /build/source/dist /build/source
  Processing ./hass_nabucasa-0.34.6-py3-none-any.whl
  Requirement already satisfied: snitun==0.20 in /nix/store/isigg4afay72dhdpb09nvkskg0adr9s4-python3.7-snitun-0.20/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (0.20)
  Requirement already satisfied: pytz>=2019.3 in /nix/store/6rn7hm563c069iz42jbal280yxm6p90i-python3.7-pytz-2020.1/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (2020.1)
  Requirement already satisfied: acme in /nix/store/vf82vnbhlvch27mkvbpq9jwbch300r1v-python3.7-acme-1.6.0/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (1.6.0)
  Requirement already satisfied: atomicwrites==1.4.0 in /nix/store/78jqz31f89r4rj4lc5qz66wrg84zdj2d-python3.7-atomicwrites-1.4.0/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (1.4.0)
  Requirement already satisfied: aiohttp~=3.6.1 in /nix/store/ncm6hz810zgayphnmajh83f74p65y4vk-python3.7-aiohttp-3.6.2/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (3.6.2)
  Requirement already satisfied: attrs~=19.3.0 in /nix/store/4hw563pg77nq7lfysqyk124y5a7ld4sf-python3.7-attrs-19.3.0/lib/python3.7/site-packages (from hass-nabucasa==0.34.6) (19.3.0)
  ERROR: Could not find a version that satisfies the requirement cryptography~=2.8 (from hass-nabucasa==0.34.6) (from versions: none)
  ERROR: No matching distribution found for cryptography~=2.8 (from hass-nabucasa==0.34.6)

Bumping the major version should most likely be fine then.

Update: Will cancel nixpkgs-review now at [2/3213/3635 built (188 failed) (still no failures related to this PR).

@primeos primeos marked this pull request as ready for review July 22, 2020 14:02
@FRidh
Copy link
Member

FRidh commented Jul 22, 2020

@GrahamcOfBorg build python2.pkgs.cryptography

@FRidh FRidh merged commit 434a011 into NixOS:staging Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @FRidh