New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gnupg20: drop #93545
gnupg20: drop #93545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an entry to pkgs/top-level/aliases.nix
so that if anyone still has this in their configuration gets a nice error?
has been EOL since 2017-12-31
The build fails now because the patch is missing. I can't see the patch to compare. But does https://gitlab.gnome.org/GNOME/libcryptui/-/commit/b05e301d1b264a5d8f07cb96e5edc243d99bff79.patch apply cleanly? If so, you could also |
Oops. I should pay more attention when using git. The patch does not apply cleanly, because the release |
Thanks, looks good! One thing I forgot to mention: it would probably add the removal to the list of Backward Incompatibilities in the release notes ( |
I would argue that this is not a relevant enough change to warrant documentation in the release notes. This version was only used in one package, because it specifically checked for a version, but supporting anything newer didn't require any actual code changes in that package's source code. It's also been unsupported upstream for years and the only reason that it wasn't dropped is probably that everyone collectively forgot it existed. IMHO the alias is enough. (And yes, I admit it, I also really don't want to write XML.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough! Looks good to me otherwise.
Result of nixpkgs-review pr 93545
1
2 packages built:
- almanah
- libcryptui
Motivation for this change
Upstream hasn't been maintaining this version for years. https://gnupg.org/download/index.html
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)