Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnupg20: drop #93545

Merged
merged 2 commits into from Jul 22, 2020
Merged

gnupg20: drop #93545

merged 2 commits into from Jul 22, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jul 20, 2020

Motivation for this change

Upstream hasn't been maintaining this version for years. https://gnupg.org/download/index.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry to pkgs/top-level/aliases.nix so that if anyone still has this in their configuration gets a nice error?

has been EOL since 2017-12-31
@danieldk
Copy link
Contributor

The build fails now because the patch is missing.

I can't see the patch to compare. But does https://gitlab.gnome.org/GNOME/libcryptui/-/commit/b05e301d1b264a5d8f07cb96e5edc243d99bff79.patch apply cleanly? If so, you could also fetchPatch that patch.

@ajs124
Copy link
Member Author

ajs124 commented Jul 22, 2020

Oops. I should pay more attention when using git.

The patch does not apply cleanly, because the release configure.ac only has gnupg 2.0, whereas the patch is against one that also has 2.1. We could also patch the patch or try finding the patch that adds that and apply both, but this option seemed the most straightforward.

@danieldk
Copy link
Contributor

Thanks, looks good! One thing I forgot to mention: it would probably add the removal to the list of Backward Incompatibilities in the release notes ( nixos/doc/manual/release-notes/rl-2009.xml ). Sorry for missing that in the first review!

@ajs124
Copy link
Member Author

ajs124 commented Jul 22, 2020

I would argue that this is not a relevant enough change to warrant documentation in the release notes. This version was only used in one package, because it specifically checked for a version, but supporting anything newer didn't require any actual code changes in that package's source code.

It's also been unsupported upstream for years and the only reason that it wasn't dropped is probably that everyone collectively forgot it existed. IMHO the alias is enough.

(And yes, I admit it, I also really don't want to write XML.)

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough! Looks good to me otherwise.

Result of nixpkgs-review pr 93545 1

2 packages built:
- almanah
- libcryptui

@danieldk danieldk merged commit 7aa79a7 into NixOS:master Jul 22, 2020
@ajs124 ajs124 deleted the drop/gnupg20 branch July 22, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants