nixos/tinc: allow configuration of RSA private key file #93538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for VPNs where some of the nodes run pre-1.1 versions. Most of Linux distros [0] and even the nixpkgs.tinc attribute run on that version, so it might be useful to have that option. [0] https://repology.org/project/tinc/versions
erictapen
force-pushed
the
tinc-rsa-key-file
branch
from
44a6f19
to
1192255
Compare
mweinelt
reviewed
Jul 26, 2020
| [ -f "/etc/tinc/${network}/rsa_key.priv" ] || tinc -n ${network} generate-rsa-keys 4096 | ||
| ''} | ||
| # In case there isn't anything to do | ||
| true |
There was a problem hiding this comment.
I don't quite understand the need for these two lines.
There was a problem hiding this comment.
If data.rsaed25519PrivateKeyFile != null && data.rsaPrivateKeyFile != null, then the then block would be empty, which is not permitted in bash. Therefore the noop.
xeji
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is necessary for VPNs where some of the nodes run pre-1.1 versions, as those nodes can't use Ed25519 keys.
Most of Linux distros and even the
nixpkgs.tincattribute run on that version, so it might be useful to have that option.Things done
Created a new option to use RAS key files. I ran this for three months now without an issue.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)