Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minikube: 0.12.0 -> 0.12.1 #93551

Merged
merged 1 commit into from Jul 20, 2020
Merged

minikube: 0.12.0 -> 0.12.1 #93551

merged 1 commit into from Jul 20, 2020

Conversation

Chili-Man
Copy link
Contributor

Motivation for this change

Upgrade minikube to the latest version available

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

prusnak
prusnak requested changes Jul 20, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change commit message to: minikube: 0.12.0 -> 0.12.1

pkgs/applications/networking/cluster/minikube/default.nix Outdated Show resolved Hide resolved
@Chili-Man Chili-Man changed the title Minikube 0.12.0 --> 0.12.1 Minikube 0.12.0 -> 0.12.1 Jul 20, 2020
@Chili-Man
Copy link
Contributor Author

@prusnak thanks for the feedback, I have addressed all your comments.

@prusnak
Copy link
Member

prusnak commented Jul 20, 2020

@GrahamcOfBorg build minikube

@Chili-Man Chili-Man changed the title Minikube 0.12.0 -> 0.12.1 minikube: 0.12.0 -> 0.12.1 Jul 20, 2020
@zowoq
Copy link
Contributor

zowoq commented Jul 20, 2020

@ofborg build docker-machine-hyperkit docker-machine-kvm2

@zowoq zowoq merged commit e5bd886 into NixOS:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@copumpkin copumpkin Awaiting requested review from copumpkin

@ebzzry ebzzry Awaiting requested review from ebzzry

@kalbasit kalbasit Awaiting requested review from kalbasit

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Chili-Man @prusnak @zowoq