Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factorio{,-headless}-experimental: 0.18.34 -> 0.18.36 #93525

Merged
merged 1 commit into from Jul 20, 2020
Merged

factorio{,-headless}-experimental: 0.18.34 -> 0.18.36 #93525

merged 1 commit into from Jul 20, 2020

Conversation

priegger
Copy link
Contributor

@priegger priegger commented Jul 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from erictapen, elitak and Baughn July 20, 2020 13:01
@priegger
Copy link
Contributor Author

Result of nixpkgs-review pr 93525 1

2 packages built:
- factorio-experimental
- factorio-headless-experimental

@bhipple
Copy link
Contributor

bhipple commented Jul 20, 2020

Result of nixpkgs-review pr 93525 1

1 package failed to build:
- factorio-experimental
1 package built:
- factorio-headless-experimental

@bhipple
Copy link
Contributor

bhipple commented Jul 20, 2020

Looks like the hash changed?

hash mismatch in fixed-output derivation '/nix/store/qvn9hvxcxrfsinjkn5l67hq1yz1pnm0m-factorio_alpha_x64-0.18.36.tar.xz':
  wanted: sha256:0la4590lf4gssdcf29qm73mz901dnp7cii712fcqw382qh9hbl9q
  got:    sha256:0r94hxmpqcgsjycpc3nf9n84l40g8zxf2kn4mrc0s7rnpymkyynw

@priegger
Copy link
Contributor Author

Thanks for reviewing my pr!

factorio-headless-experimental can be downloaded without authentication, factorio-experimental can only be downloaded with authentication.

Do you have a factorio account/token and do you have it configured?

erictapen
erictapen approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me.

@erictapen erictapen merged commit 7d1b94b into NixOS:master Jul 20, 2020
@bhipple
Copy link
Contributor

bhipple commented Jul 20, 2020

Aha, forgot that this one had to be enabled. It'd be nice if we could detect that case and give a nicer assert error msg, perhaps. At any rate LGTM 👍

@priegger priegger deleted the fix/factorio-update branch July 20, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen erictapen approved these changes

@elitak elitak Awaiting requested review from elitak

@Baughn Baughn Awaiting requested review from Baughn

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@priegger @bhipple @erictapen