Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kata-containers: init at 1.11.2 #93526

Closed

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Package kata-containers for nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Testing
nix-build -A kata-containers.runtime-qemu
bundle="/tmp/bundle"
rootfs="$bundle/rootfs"
sudo docker export $(sudo docker create busybox) | tar -C "$rootfs" -xvf -
mkdir -p "$rootfs" && (cd "$bundle" && <nixpkgs>/result/bin/kata-runtime spec)
sudo result/bin/kata-runtime --log=/dev/stdout run --bundle="$bundle" --console= --pid-file=/tmp/pid foo

CC @adisbladis @zowoq @saschagrunert @vdemeester

@offlinehacker
Copy link
Contributor Author

I am planning to integrate into podman nixos module as runtime and also using rootless podman into home-manager. No plan to integrate into kubernetes for now, since i do not need.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a single question about the maintainer name :)

@offlinehacker
Copy link
Contributor Author

@GrahamcOfBorg build kata-containers

@offlinehacker
Copy link
Contributor Author

If someone is brave enough to build kernel/initrd/image using nixos, it would be super awesome. For now i have no plan, i just want secure dev environments that can run nixos based container with systemd and podman in podman.

@zowoq
Copy link
Contributor

zowoq commented Jul 20, 2020

@ofborg build kata-containers

];
});

in {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this entire file a scope with a custom callPackage to better facilitate overrides.

If you're unsure how to do this here is an example: https://github.com/NixOS/nixpkgs/pull/82651/files#diff-a973f074566d70690afdc544e72c14a2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that you have several derivations here, I completely agree. I would be willing to merge if you could just accomodate this request, as the rest looks good to me. Thank you!

@saschagrunert
Copy link
Member

@offlinehacker can you please rebase? I'd like to get this in as well :)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/vision-for-container-hosting-handling/2017/8

jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
jcvenegas added a commit to jcvenegas/nixpkgs-katacontainers that referenced this pull request Jan 30, 2021
@stale
Copy link

stale bot commented Jul 8, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 8, 2021
];
});

in {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that you have several derivations here, I completely agree. I would be willing to merge if you could just accomodate this request, as the rest looks good to me. Thank you!

@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Sep 11, 2021
@zowoq
Copy link
Contributor

zowoq commented Sep 11, 2021

https://medium.com/kata-containers/about-kata-containers-releases-8b3d91d1166e

1.x is no longer being maintained

Kata Containers 1.x has reached EOL (End of Life) and is no longer being maintained, the repositories have been archived, and all the issues were closed.

Closing as 1.* is now EOL. 2.* switched to a go/rust monorepo so this would need to be rewritten.

@zowoq zowoq closed this Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants