New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kata-containers: init at 1.11.2 #93526
Conversation
I am planning to integrate into podman nixos module as runtime and also using rootless podman into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a single question about the maintainer name :)
1629f0a
to
4e7b2b9
Compare
4e7b2b9
to
3da168e
Compare
3da168e
to
4c15215
Compare
@GrahamcOfBorg build kata-containers |
If someone is brave enough to build kernel/initrd/image using nixos, it would be super awesome. For now i have no plan, i just want secure dev environments that can run nixos based container with systemd and podman in podman. |
4c15215
to
3447d8c
Compare
@ofborg build kata-containers |
]; | ||
}); | ||
|
||
in { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make this entire file a scope with a custom callPackage
to better facilitate overrides.
If you're unsure how to do this here is an example: https://github.com/NixOS/nixpkgs/pull/82651/files#diff-a973f074566d70690afdc544e72c14a2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that you have several derivations here, I completely agree. I would be willing to merge if you could just accomodate this request, as the rest looks good to me. Thank you!
@offlinehacker can you please rebase? I'd like to get this in as well :) |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/vision-for-container-hosting-handling/2017/8 |
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
kata overlay base in https://lucperkins.dev/blog/nix-channel/ and NixOS/nixpkgs#93526
I marked this as stale due to inactivity. → More info |
]; | ||
}); | ||
|
||
in { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that you have several derivations here, I completely agree. I would be willing to merge if you could just accomodate this request, as the rest looks good to me. Thank you!
https://medium.com/kata-containers/about-kata-containers-releases-8b3d91d1166e
Closing as |
Motivation for this change
Package
kata-containers
for nixpkgs.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Testing
CC @adisbladis @zowoq @saschagrunert @vdemeester