New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add github action to wait for ofborg #93581
Conversation
9b5330c
to
dc8225b
Compare
@GrahamcOfBorg build hello |
3396bd0
to
b7ab073
Compare
@GrahamcOfBorg build hello |
.github/workflows/wait-ofborg.yml
Outdated
res=$(curl --silent \ | ||
-H "Accept: application/vnd.github.antiope-preview+json" \ | ||
-H "Authorization: token ${GITHUB_TOKEN}" \ | ||
"https://api.github.com/repos/NixOS/nixpkgs/commits/${GITHUB_SHA}/check-runs" | \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That commit still seems wrong...
179a21b
to
c10fc81
Compare
@GrahamcOfBorg build hello |
@GrahamcOfBorg eval |
Something that might be an issue with this approach is the limits on github actions, if ofborg goes down we'll start burning through our allocation. |
It is limited to 10min. How much time on github actions do we have? |
Which could end up adding up quickly if ofborg does down for any length of time. |
Where do you have the information from that we have limits? This looks like there are only for private repos: https://docs.github.com/en/github/setting-up-and-managing-billing-and-payments-on-github/managing-your-spending-limit-for-github-actions#about-spending-limits-for-github-actions |
Ah, must have misremembered. Concurrent jobs and API requests may be an issue? |
Not really. It would just means that the job is started later... |
In case ofborg is down this will not mark the CI as green. Also if other github actions are used and pass checks will be still marked as pending even if other other github actions have passed.
Any idea why ofborg is not picking up this PR? Do I need to modify nix files? |
@GrahamcOfBorg eval |
1 similar comment
@GrahamcOfBorg eval |
No. AFAIK, you shouldn't need to modify a nix file for it to start. I have noticed that ofborg has been a bit flakey the last day or two, not picking up pushes or stopping after eval/meta checks and not triggering builds. |
Let's keep the |
This is working now. In case it timeouts its still clear that ofborg should have been run so users are not tricked into thinking that the CI run successfully. |
Let's see how this works out in practice. |
Should we disable the actions for now until we get the required checks working? The timeout job is a nice workaround but I think the drawbacks may be outweighing the benefits of having it just for the editorconfig check. |
This is a problem with or without github actions. If someone triggers ofborg build it will mark the build as green. I don't see how this is worth than the status quo. In fact having github actions increases seeing the absence of ofborg runs. If ofborg is down for example github actions would still mark the build as failed. So just having the |
There was a 3hr wait for ofborg evals earlier, needed to clear a page of errored PRs after ofborg caught up. |
Let's continue discussion in #94658 |
In case ofborg is down this will not mark the CI as green.
Also if other github actions are used and pass
checks will be still marked as pending even if other other github
actions have passed.