Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lokalise2: init at 2.6.0 #93546

Merged
merged 1 commit into from Aug 9, 2020
Merged

lokalise2: init at 2.6.0 #93546

merged 1 commit into from Aug 9, 2020

Conversation

timstott
Copy link
Contributor

@timstott timstott commented Jul 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • Add license (blocked on Add license lokalise/lokalise-cli-2-go#38)

@ofborg ofborg bot requested a review from kalbasit July 21, 2020 19:57
@timstott timstott marked this pull request as ready for review July 31, 2020 16:02
@timstott timstott changed the title lokalise2: init at 2.5.1 lokalise2: init at 2.6.0 Aug 6, 2020
jonringer
jonringer reviewed Aug 7, 2020
View reviewed changes
pkgs/tools/misc/lokalise2-cli/default.nix Outdated
pname = "lokalise2-cli";
version = "2.6.0";

goPackagePath = "github.com/lokalise/lokalise-cli-2-go";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't get used with buildGoModule

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review @jonringer. I've amended the commit your feedback.

jonringer
jonringer approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 93546 1

1 package built:
- lokalise2-cli

@jonringer jonringer merged commit df53f4f into NixOS:master Aug 9, 2020
@timstott timstott deleted the lokalise2 branch August 10, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timstott @jonringer