Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

okteto: init at 1.8.15 #93583

Closed
wants to merge 1 commit into from
Closed

okteto: init at 1.8.15 #93583

wants to merge 1 commit into from

Conversation

offlinehacker
Copy link
Contributor

Motivation for this change

Okteto is a tool that allows you to develop your code inside kubernetes cluster.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit July 21, 2020 09:26
@teto
Copy link
Member

teto commented Jul 21, 2020

I dont need kubernetes to feel good but thanks I guess :)

@dasj19
Copy link
Contributor

dasj19 commented Jul 21, 2020

Tested with: nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93583", You can check the 3rd checkbox in the description.

It builds and runs fine.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 93583 run on x86_64-linux 1

1 package built:
  • okteto

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 93583 run on x86_64-darwin 1

1 package built:
  • okteto

@dasj19
Copy link
Contributor

dasj19 commented Apr 29, 2021

Can you apply Sandro's suggestion so we can approve and merge? Thanks.

@SuperSandro2000
Copy link
Member

In the future please turn on that maintainers can edit the PR which makes small, last minute changes easy.

@ofborg eval

SuperSandro2000
SuperSandro2000 requested changes Apr 30, 2021
View reviewed changes
pkgs/development/tools/okteto/default.nix
pname = "okteteo";
version = "1.8.15";

goPackagePath = "github.com/okteto/okteto";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed but I am not sure why ofborg does not fail because it does when I manually build it.

error: `goPackagePath` is not needed with `buildGoModule`

pkgs/development/tools/okteto/default.nix
Comment on lines +15 to +22
src = fetchFromGitHub {
owner = "okteto";
repo = "okteto";
rev = version;
sha256 = "0eFo0gYciLoHIebMRMqrOMMclG23D9mRoxCQIffvSP0=";
};

vendorSha256 = "5F/SXs5jqLfZXqXPO93KCfDneDcCZNzjhYJ4jqzkfuw=";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this under version where it is commonly found.

@stale
Copy link

stale bot commented Oct 30, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 30, 2021
@Mindavi
Copy link
Contributor

Mindavi commented Nov 27, 2021

@offlinehacker are you willing to push this over the finish line? A rebase and application of the minor suggestions should go a long way 😃

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 27, 2021
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022
@aaronjheng
Copy link
Contributor

I think we can close this PR now.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@offlinehacker @teto @dasj19 @SuperSandro2000 @Mindavi @aaronjheng