Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-gyp: update with python3 support + drop python2 dependency in nss build #93534

Merged
merged 3 commits into from Jul 20, 2020
Merged

python-gyp: update with python3 support + drop python2 dependency in nss build #93534

merged 3 commits into from Jul 20, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Jul 20, 2020 •
edited

Motivation for this change

Follow-up (of sorts) to #91746

This probably doesn't fix the darwin build, but at least it drops the python2 dependency.
Should have checked this sooner…

cc @vcunat @flokli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124
pythonPackages.gyp: 2015-06-11 -> 2020-05-12
6f77852 
upstream doesn't do stable releases, but this seems to support python3 now
@ajs124
nss: gyp supports python3 now
6760ec6
@vcunat
Copy link
Member

vcunat commented Jul 20, 2020

Well, why not try a darwin build anywa; deps should be in cache ATM.
@GrahamcOfBorg build nss

@vcunat
Copy link
Member

vcunat commented Jul 20, 2020

🤔 "No such file or directory" with a different file, though it's possible that was non-deterministic in the first place. I'll assume this PR is independent of the darwin problems.

@ofborg ofborg bot requested a review from codyopel July 20, 2020 14:59
@ajs124
Copy link
Member Author

ajs124 commented Jul 20, 2020

The missing thing always seems to be libtool, so we can just try and give it libtool and see what that does.

@vcunat
Copy link
Member

vcunat commented Jul 20, 2020

Oh, I missed that. OK.
@GrahamcOfBorg build nss

@vcunat
Copy link
Member

vcunat commented Jul 20, 2020

By a quick search on the internet, I suspect we want libtool from darwin.cctools package. (I'm probably not allowed to push into this branch.)

@flokli
Copy link
Contributor

flokli commented Jul 20, 2020

@GrahamcOfBorg build nss

1 similar comment
@flokli
Copy link
Contributor

flokli commented Jul 20, 2020

@GrahamcOfBorg build nss

@ajs124
Copy link
Member Author

ajs124 commented Jul 20, 2020

cc @NixOS/darwin-maintainers this times out on ofborg

@vcunat
Copy link
Member

vcunat commented Jul 20, 2020

Timed out at [1217/1220]... so that libtool error seems fixed for sure and even overall I think there's good chance it will be OK.

@flokli
Copy link
Contributor

flokli commented Jul 20, 2020

I tried reproduce this on a borrowed Mac,

For some reason, I ran into some No such file or directory: xcodebuild errors, which don't occur on ofborg. I was able to migitate the by also adding some of the frameworks and xcbuild, but I don't feel qualified to decide on whether this is necessary or not, given it seems to not occur on ofborg. I defer to @LnL7 on that.

@vcunat
Copy link
Member

vcunat commented Jul 20, 2020 •
edited

Could that have been due to you not using sandboxing?

@flokli
Copy link
Contributor

flokli commented Jul 20, 2020

Could that have been due to you not using sandboxing?

With sandboxing enabled, the sandbox complained trying to invoke xcodebuild, without it, MacOS complained about xcode not being installed properly.

I don't really know - I hope if ofborg builds, hydra will do so aswell. I really am not familiar enough with this architecture to judge.

LnL7
LnL7 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The darwin build succeeded on 2 different hosts.

@flokli not sure what caused your issue, but at least it shouldn't happen on hydra from what I can tell

@flokli flokli merged commit 29d0b7b into NixOS:staging Jul 20, 2020
@ajs124 ajs124 deleted the gyp-python3 branch July 20, 2020 20:49
@vcunat
Copy link
Member

vcunat commented Jul 21, 2020 •
edited

Confirmed on Hydra 🎉 https://hydra.nixos.org/build/124199611

@vcunat vcunat mentioned this pull request Aug 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @vcunat @flokli @LnL7