Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mod_cspnonce: init at 1.3 #93527

Merged
merged 1 commit into from Jan 10, 2022
Merged

mod_cspnonce: init at 1.3 #93527

merged 1 commit into from Jan 10, 2022

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Jul 20, 2020

Motivation for this change

Packaged mod_cspnonce which deals with Content Security Policy.
This module enables a carefully generated nonce to be added in the server headers and thus improving CSP of the server.

I have it running on my server and works like a charm.

The way I have it running is:

  services.httpd.extraModules = [
    "rewrite" "headers" "proxy" "proxy_http" "proxy_ftp"
    { name = "cspnonce"; path = "${pkgs.mod_cspnonce}/modules/mod_cspnonce.so"; }
  ];

and...

  services.httpd.virtualHosts."searx.gnu.style".extraConfig = ''
    Header set Content-Security-Policy "script-src 'self' 'nonce-%{CSP_NONCE}e';
  '';
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasj19 dasj19 mentioned this pull request Jul 20, 2020
Closed
@dasj19
Copy link
Contributor Author

dasj19 commented Aug 10, 2020

CC'ing other httpd module maintainers, for review: @jglukasik @dirkx @womfoo
Thanks,

@aanderse
Copy link
Member

I wonder if @jtojnar might find some time to review this...

@stale
Copy link

stale bot commented Sep 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 19, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 21, 2021
dirkx
dirkx approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@dirkx dirkx left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luvely & builds (though at some point we ought to fix the random generation in the original module - as it is not cryptographically secure). Added an issue wyday/mod_cspnonce#8 and a potential fix wyday/mod_cspnonce#9

@aanderse
Copy link
Member

aanderse commented Jan 2, 2022

Any objections to merge? @SuperSandro2000?

@aanderse aanderse merged commit 52d4c01 into NixOS:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@dirkx dirkx dirkx approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dasj19 @aanderse @dirkx @jtojnar @SuperSandro2000