Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lv2: fix build on darwin #93528

Merged
merged 3 commits into from Jul 20, 2020
Merged

lv2: fix build on darwin #93528

merged 3 commits into from Jul 20, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam changed the title Fix lv2 darwin build lv2: fix build on darwin Jul 20, 2020
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Jul 20, 2020
@ofborg ofborg bot requested a review from cillianderoiste July 20, 2020 13:26
@marsam marsam merged commit e8b9aa8 into NixOS:master Jul 20, 2020
@marsam marsam deleted the fix-lv2-darwin-build branch July 20, 2020 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marsam