New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update friture to master branch, add necessary python packages #93543
Conversation
|
||
meta = { | ||
description = "Reliable low-latency audio playback and recording with Python, using PortAudio via the sounddevice module"; | ||
homepage = "https://python-rtmixer.readthedocs.io/en/0.1.1/"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add license
Ahoy, I added the licenses and changed the date format. Also, I removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than these nits this looks good!
pkgs/development/python-modules/pyopengl-accelerate/default.nix
Outdated
Show resolved
Hide resolved
428792a
to
81d1743
Compare
This should do the trick! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERROR: sounddevice-0.4.0-py3-none-any.whl is not a supported wheel on this platform.
builder for '/nix/store/594mvbqv48mlkmsm93m5bijkkkdv2g3s-python2.7-sounddevice-0.4.0.drv' failed with exit code 1
warning: SQLite database '/nix/var/nix/db/db.sqlite' is busy
cannot build derivation '/nix/store/g0q3l4gqzilpziak6akvcm8mf4rqhhwz-python2.7-rtmixer-0.1.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1q5vzybkxdqvvgh1qi8gzj25pdbqbcw4-env.drv': 1 dependencies couldn't be built
81d1743
to
7b29766
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 93543 1
9 packages built:
- friture
- python27Packages.pa-ringbuffer
- python27Packages.pyopengl-accelerate
- python37Packages.pa-ringbuffer
- python37Packages.pyopengl-accelerate
- python37Packages.rtmixer
- python38Packages.pa-ringbuffer
- python38Packages.pyopengl-accelerate
- python38Packages.rtmixer
Motivation for this change
Package upgrade. I didn't upgrade to v0.41 because there were two issues with it that broke the package.
I didn't run tests for the python packages added with these commits, but friture seems to be able to use them.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)