Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librealsense: add pyrealsense2 Python bindings + command line tools #93552

Closed
wants to merge 1 commit into from
Closed

librealsense: add pyrealsense2 Python bindings + command line tools #93552

wants to merge 1 commit into from

Conversation

tpwrules
Copy link
Contributor

Motivation for this change

Python bindings are a big use case for librealsense. I've named them "pyrealsense2" after the package on PyPI. I also turned on building of the command line examples as these are useful for validating operation of the library.

NOTE: testing this package isn't really possible without owning one of the supported cameras. I have some and have tested them appropriately on all Python versions and with the example binaries.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from brian-dawn July 20, 2020 19:56
@brian-dawn
Copy link
Member

Hi thanks for the changes! #92997 is currently open which also adds Python as well as CUDA support. It doesn't look like that one handles IntelRealSense/meta-intel-realsense#20 so maybe some coordination is needed here?

@tpwrules
Copy link
Contributor Author

Closing in favor of #92997

@tpwrules tpwrules closed this Jul 21, 2020
@tpwrules tpwrules deleted the librealsense-update branch July 21, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@brian-dawn brian-dawn Awaiting requested review from brian-dawn

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tpwrules @brian-dawn