Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.ImageExifTool: 11.85 -> 12.00 #93555

Merged
merged 1 commit into from Jul 22, 2020
Merged

perlPackages.ImageExifTool: 11.85 -> 12.00 #93555

merged 1 commit into from Jul 22, 2020

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Jul 20, 2020

Motivation for this change

https://exiftool.org/history.html#v12.00

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member

prusnak commented Jul 20, 2020

Please change the commit message to: perlPackages.exiftool: 11.85 -> 12.00

@thorstenweber83
Copy link
Contributor

Result of nixpkgs-review pr 93555 1

10 packages built:
- digikam
- exiftool (perl530Packages.ImageExifTool)
- fgallery
- hugin
- pdf-redact-tools
- perl528Packages.ImageExifTool
- rapid-photo-downloader
- shutter
- styx
- timelapse-deflicker

stigtsp
stigtsp reviewed Jul 21, 2020
View reviewed changes
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
pkgs/top-level/perl-packages.nix Outdated Show resolved Hide resolved
@dywedir
Copy link
Member Author

dywedir commented Jul 21, 2020

Thanks! All done

@dywedir dywedir changed the title exiftool: 11.85 -> 12.00 perlPackages.ImageExifTool: 11.85 -> 12.00 Jul 21, 2020
stigtsp
stigtsp approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@danieldk danieldk merged commit 2f1e205 into NixOS:master Jul 22, 2020
@dywedir dywedir deleted the exiftool branch July 27, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak left review comments

@danieldk danieldk danieldk approved these changes

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dywedir @prusnak @thorstenweber83 @danieldk @stigtsp