haskellPackages.splot: fix build #93557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build splot |
| @@ -1391,4 +1391,9 @@ self: super: { | |||
| gi-soup = doJailbreak super.gi-soup; | |||
| gi-webkit2 = doJailbreak super.gi-webkit2; | |||
|
|
|||
| # Upstream PR: https://github.com/jkff/splot/pull/9 | |||
| splot = appendPatch (unmarkBroken super.splot) (pkgs.fetchpatch { | |||
There was a problem hiding this comment.
@basvandijk Thanks for trying to fix this up.
However, instead of using unmarkBroken here, can you rebase this change on the haskell-updates branch, and remove splot from the list of broken-packages in configuration-hackage2nix.yaml?
basvandijk
force-pushed
the
haskellPackages.splot
branch
from
927418f
to
04377fe
Compare
Also introduce the top-level `splot` package which only provides the statically linked `splot` binary.
basvandijk
force-pushed
the
haskellPackages.splot
branch
from
04377fe
to
bdad554
Compare
|
Builds for me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I needed a working version of the old Haskell-based
splottool.Also introduce the top-level
splotpackage which only provides the statically linkedsplotbinary.Things done
This commit fixes the
splothaskell package and also introduces the top-levelsplotpackage which only provides the statically linkedsplotbinary.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)