Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

androidStudioPackages.beta: 4.0.0.16 -> 4.1.0.14 #93558

Merged
merged 3 commits into from Jul 21, 2020
Merged

androidStudioPackages.beta: 4.0.0.16 -> 4.1.0.14 #93558

merged 3 commits into from Jul 21, 2020

Conversation

Galagora
Copy link
Contributor

@Galagora Galagora commented Jul 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Galagora Galagora mentioned this pull request Jul 20, 2020
Closed
primeos
primeos requested changes Jul 21, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit message should use the attribute name instead of pname i.e.: androidStudioPackages.beta: 4.0.0.16 -> 4.1.0.14. Seems like our documentation is misleading here.

Edit: And for the first commit maintainers: add galagora looks way more common from the Git history.

The rest LGTM.

pkgs/applications/editors/android-studio/common.nix Show resolved Hide resolved
@ghost ghost mentioned this pull request Jul 21, 2020
Merged
10 tasks
@Galagora Galagora changed the title Update Android Studio Beta androidStudioPackages.beta: 4.0.0.16 -> 4.1.0.14 Jul 21, 2020
@Galagora Galagora requested a review from primeos July 21, 2020 15:47
@Galagora
Copy link
Contributor Author

I added the dev channel, renamed the two commits, and force pushed.

primeos
primeos requested changes Jul 21, 2020
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@Galagora
Copy link
Contributor Author

Hey @meutraa do you want me to add you to the maintainers? I stashed some changes to that effect.

@ghost
Copy link

ghost commented Jul 21, 2020

Yeah, go for it, stable and canary.

@Galagora
Copy link
Contributor Author

What's your name and email?

@ghost
Copy link

ghost commented Jul 21, 2020 •
edited by ghost

Paul Meredith paul+nixpkgs@lost.host

@Galagora Galagora requested a review from primeos July 21, 2020 16:59
primeos
primeos approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks :)

@primeos primeos merged commit 9a47c3b into NixOS:master Jul 21, 2020
This was referenced Feb 24, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Galagora @primeos @Janik-Haag