Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portfolio: 0.46.6 -> 0.47.0 #93822

Merged
merged 1 commit into from Aug 9, 2020
Merged

portfolio: 0.46.6 -> 0.47.0 #93822

merged 1 commit into from Aug 9, 2020

Conversation

oyren
Copy link
Contributor

@oyren oyren commented Jul 25, 2020 •
edited

Motivation for this change

Update of portfolio performance to 0.47.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from elohmeier July 25, 2020 14:46
@dasj19
Copy link
Contributor

dasj19 commented Jul 27, 2020

Tested with: nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93822". Builds and runs just fine.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/193

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/200

@danieldk danieldk merged commit a5d6a46 into NixOS:master Aug 9, 2020
@oyren oyren deleted the update-portfolio branch August 24, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elohmeier elohmeier elohmeier approved these changes

@dasj19 dasj19 dasj19 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oyren @dasj19 @nixos-discourse @elohmeier @danieldk