Ensure wpa_supplicant.conf is written when userControlled and extraConfig are used #93813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure wpa_supplicant.conf is also generated when userControlled and extraConfig are used. (As discussed in issue NixOS#59959)
infinisil
approved these changes
Jul 25, 2020
There was a problem hiding this comment.
Looking good to me. This technically isn't backwards compatible for people that have no networks specified but do have userControlled.enable or extraConfig specified. But I don't think this is a big problem because these settings didn't have an effect in this case before this change.
mweinelt
approved these changes
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Issue #59959 shows that wpa_supplicant.conf is only generated if the user specifies networks. However, it should also be generated if either extraConfig or userControlled is specified. This PR adds that.
Things done
Testing this change locally is underway.I have a hard time figuring out how to test this change without booting my system from nixpkgs/master. But if that's needed I can try.I applied the patch to the release-20.03 branch, booted my install off of it, and it worked as expected locally (that is:wpa_clienters an interactive prompt with onlyuserControlled = truein my configuration.nix).sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)