tilt: 0.11.3 -> 0.16.1, move to buildGoModule #93827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sikmir
reviewed
Jul 29, 2020
|
|
||
| subPackages = [ "cmd/tilt" ]; | ||
|
|
||
| buildFlagsArray = ("-ldflags=-X main.version=${version} -X main.date=2020-01-25"); | ||
| buildFlagsArray = [ "-ldflags=-X main.version=${version} -X main.date=2020-07-23" ]; |
There was a problem hiding this comment.
What does this date mean? If that's release date, 0.16.1 was released 2020-07-17. If that's build date, it doesn't make sense here and should be undefined.
There was a problem hiding this comment.
Agreed, I've now removed this. Thanks for the review, a new version has come out since this - lets continue in #94827. Cheers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Application version bump with move to their new repo and little changes to get the build working again on latest updates.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)