Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

squeezer: init at 2.5.4 #93816

Closed
wants to merge 1 commit into from
Closed

squeezer: init at 2.5.4 #93816

wants to merge 1 commit into from

Conversation

jpotier
Copy link
Contributor

@jpotier jpotier commented Jul 25, 2020

Motivation for this change

New VST

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jpotier
Copy link
Contributor Author

jpotier commented Jul 25, 2020

One big drawback about this is the need for VST2 SDK… I don't think we can merge this as is in nixpkgs, for licensing matters.

I'm open to suggestions on how to fix this, it would be nice to have squeezer-vst available in nixos by default, for audio people like myself.

I could cheat and bundle pre-built binary vst, but I find it silly to do so, when the project is GPLv3

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/how-do-we-deal-with-packaging-vst2-plugins/8304/1

@magnetophon
Copy link
Member

@jpotier Thanks! A while ago, I tried to package it as well, but gave up...

@jpotier
Copy link
Contributor Author

jpotier commented Jul 27, 2020

So, this PR needs either:

  • help in figuring out how to build the VST2 version without legal problems, or
  • wait, until the upstream repo includes a VST3 version of it that we can distribute.

Meanwhile, this package definition is working (I'm using it in a personal overlay) and you can use this if you want to add squeezer to your VST collection on NixOS, by creating an overlay and adding it manually.

@stale
Copy link

stale bot commented Jul 20, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 20, 2021
@jpotier
Copy link
Contributor Author

jpotier commented Mar 29, 2022

This is stale, and I'm not actively working on it anymore. Anyone, feel free to reopen as your own if you're interested.

@jpotier jpotier closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants