Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sublime-music: init at 0.11.0 #93817

Merged
merged 3 commits into from Jul 25, 2020
Merged

sublime-music: init at 0.11.0 #93817

merged 3 commits into from Jul 25, 2020

Conversation

albakham
Copy link
Member

Motivation for this change

Package the sublime-music application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@albakham
Copy link
Member Author

I splitted the commit to better understand the additions, and I did the modifications @jtojnar suggested.

@albakham albakham requested a review from jtojnar July 25, 2020 15:56
jtojnar
jtojnar reviewed Jul 25, 2020
View reviewed changes
pkgs/development/python-modules/dataclasses-json/default.nix Outdated
];

meta = with lib; {
description = "This library provides a simple API for encoding and decoding dataclasses to and from JSON.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@jtojnar jtojnar merged commit 8935ddf into NixOS:master Jul 25, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jul 25, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@albakham @jtojnar