Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makemkv: 1.15.1 -> 1.15.2 #93809

Merged
merged 2 commits into from Jul 25, 2020
Merged

makemkv: 1.15.1 -> 1.15.2 #93809

merged 2 commits into from Jul 25, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 25, 2020 •
edited

Motivation for this change

Upstream changes:

  • Massive internal rewrite, some improvements and small bugfixes
  • Muxer updated to the latest matroska specification
  • Advanced usage changes:
    • Sdftool included as standalone executable
    • Drive speed control option

(Though the archives do no actually seem to contain the aforemetioned sdftool.)

Also add myself as a maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
makemkv: 1.15.1 -> 1.15.2
12186bf 
Upstream changes:

- Massive internal rewrite, some improvements and small bugfixes
- Muxer updated to the latest matroska specification
- Advanced usage changes:
  * Sdftool included as standalone executable
  * Drive speed control option
@danieldk
makemkv: add danieldk as a maintainer
0cfaf02
@ofborg ofborg bot requested a review from titanous July 25, 2020 10:15
@danieldk danieldk merged commit 6150631 into NixOS:master Jul 25, 2020
@danieldk danieldk deleted the makemkv-1.15.2 branch August 17, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titanous titanous titanous approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @titanous