Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

papermc: 1.15.2r161 -> 1.16.1r114 #93818

Closed
wants to merge 1 commit into from
Closed

papermc: 1.15.2r161 -> 1.16.1r114 #93818

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2020 •
edited by ghost

Motivation for this change

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jul 25, 2020

Tested running it with the minecraft-server module package option on my server/world and it works fine.

@ofborg ofborg bot requested a review from aaronjanse July 25, 2020 13:27
aaronjanse
aaronjanse approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@aaronjanse aaronjanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty @meutraa!

LGTM

@ghost
Copy link
Author

ghost commented Aug 24, 2020

Closing in favour of #95386

@ghost ghost closed this Aug 24, 2020
@ghost ghost deleted the update/papermc branch August 24, 2020 00:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaronjanse @meutraa