Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetbrains.idea-ultimate: add zlib fhs #93832

Closed
wants to merge 1 commit into from
Closed

Conversation

mkg20001
Copy link
Member

Motivation for this change

Fixes #93829

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkg20001
Copy link
Member Author

Unsure if community and the others also need it, generalized the FHS as an argument so it can be easily added for others that download executables aswell

@mkg20001
Copy link
Member Author

I just realized that this could be solved aswell by adding zlib to LD_LIBRARY_PATH...

@jonringer
Copy link
Contributor

adding zlib to LD_LIBRARY_PATH..

This should be avoid as I believe it will override the existing ld path. Probably not too much of a concern with just zlib, but should probably be avoided.

@mkg20001
Copy link
Member Author

So should I go forward with the FHS or include zlib in other ways?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/333

@gytis-ivaskevicius
Copy link
Contributor

Hey @mkg20001 I tried out this patch and there is one issue - it loads whole IntelliJ into chroot and that impacts the terminal as well :/
I believe that LD_LIBRARY_PATH is the only option

@Mic92
Copy link
Member

Mic92 commented Feb 10, 2021

In rustup we solved this by having a patchelf patch that would be applied to downloaded binaries. However I assume this is not possible here since idea is not built from source. One shameless self-plug would be https://github.com/Mic92/nix-ld as a bandaid. LD_LIBRARY_PATH might work to, it just could be problematic if your development environment uses a libc different than the jetbrains IDE beeing used and it might also affect programs started as a subprocess i.e. in the integrated terminal in a negative way.

@stale
Copy link

stale bot commented Aug 10, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 10, 2021
@gytis-ivaskevicius
Copy link
Contributor

This PR should be closed since #93829 has been resolved.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 10, 2021
@mkg20001 mkg20001 closed this Aug 10, 2021
@mkg20001 mkg20001 deleted the idea-fix branch August 10, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jetbrains.idea-ultimate: Needs FHS to run downloaded JDKs
6 participants