New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jetbrains.idea-ultimate: add zlib fhs #93832
Conversation
Unsure if community and the others also need it, generalized the FHS as an argument so it can be easily added for others that download executables aswell |
I just realized that this could be solved aswell by adding zlib to LD_LIBRARY_PATH... |
This should be avoid as I believe it will override the existing ld path. Probably not too much of a concern with just zlib, but should probably be avoided. |
So should I go forward with the FHS or include zlib in other ways? |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
f637773
to
1e72954
Compare
Hey @mkg20001 I tried out this patch and there is one issue - it loads whole IntelliJ into chroot and that impacts the terminal as well :/ |
In rustup we solved this by having a patchelf patch that would be applied to downloaded binaries. However I assume this is not possible here since idea is not built from source. One shameless self-plug would be https://github.com/Mic92/nix-ld as a bandaid. LD_LIBRARY_PATH might work to, it just could be problematic if your development environment uses a libc different than the jetbrains IDE beeing used and it might also affect programs started as a subprocess i.e. in the integrated terminal in a negative way. |
I marked this as stale due to inactivity. → More info |
This PR should be closed since #93829 has been resolved. |
Motivation for this change
Fixes #93829
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)