Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mopidy-youtube: 3.0 -> 3.1 #93808

Merged
merged 1 commit into from Jul 26, 2020
Merged

mopidy-youtube: 3.0 -> 3.1 #93808

merged 1 commit into from Jul 26, 2020

Conversation

ruuda
Copy link
Contributor

@ruuda ruuda commented Jul 25, 2020

Motivation for this change

3.1 was released upstream which fixes* natumbri/mopidy-youtube#150.

* Added asterisk because GitHub otherwise marks this pull request as fixing that bug due to the magic fixes word.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested by building

buildEnv {
  name = "mopidy-with-extensions-${mopidy.version}";
  paths = lib.closePropagation [
    pkgs.mopidy-iris
    pkgs.mopidy-local
    pkgs.mopidy-youtube
  ];
  pathsToLink = [ "/${mopidyPackages.python.sitePackages}" ];
  buildInputs = [ makeWrapper ];
  postBuild = ''
    makeWrapper ${mopidy}/bin/mopidy $out/bin/mopidy \
      --prefix PYTHONPATH : $out/${mopidyPackages.python.sitePackages}
  '';
}

The upstream bug affected me, and I can confirm that this update resolved it.

@mweinelt
Copy link
Member

LGTM.

Result of nixpkgs-review pr 93808 1

1 package built:
- mopidy-youtube

@mweinelt mweinelt merged commit 4282032 into NixOS:master Jul 26, 2020
@ruuda ruuda deleted the mopidy-youtube branch July 28, 2020 16:24
@hexop hexop mentioned this pull request Jan 13, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants