Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools.buildLayeredImage: fix /nix/store permissions (regression) #93811

Closed
wants to merge 1 commit into from
Closed

dockerTools.buildLayeredImage: fix /nix/store permissions (regression) #93811

wants to merge 1 commit into from

Conversation

adrian-gierakowski
Copy link
Contributor

Set /nix and /nix/store permissions to 755 (as it used to be before #91084).

@purcell @utdemir @grahamc

Motivation for this change

Needed to allow running image as non root user.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@adrian-gierakowski adrian-gierakowski mentioned this pull request Jul 25, 2020
Merged
10 tasks
@adrian-gierakowski
dockerTools.buildLayeredImage: fix /nix/store permissions (regression)
5a8eb3b 
Needed to allow running image as non root user.

Fixes a regression introduced by NixOS#91084
@adrian-gierakowski adrian-gierakowski force-pushed the dockerTools-buildLayeredImage-fix-nix-store-permissions branch from 554d292 to 5a8eb3b Compare July 26, 2020 07:59
purcell
purcell approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@purcell purcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good to me. Thanks for catching it. I wonder if a test for this could be added?

@adrian-gierakowski
Copy link
Contributor Author

Yes, this looks good to me. Thanks for catching it. I wonder if a test for this could be added?

indeed a test would be good to have, I'll look into it later this week

@adrian-gierakowski
Copy link
Contributor Author

Closing in favour of #94243 as it includes tests already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purcell purcell purcell approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrian-gierakowski @purcell