Enable Qtile tests #93837

deliciouslytyped · 2020-07-25T18:29:31Z

Following up on qtile/qtile#1828, this enables tests for qtile.
I will disable the failing tests with a push in a few minutes, since I believe partial testing is still better than none, and then reenabling them can be worked on later.

refactor: remove rec and move version into the let expression rename python37Packages usages to "pypa" enabled tests: patch conftest to keep the nix python environment variables, this fixes all the enabled tests add test dependencies run pytest with xvfb-run with HOME set for the duration of the test

deliciouslytyped · 2020-07-25T19:30:10Z

I'm not sure but tests might be failing nondeterministically.

Lassulus · 2020-07-25T20:22:41Z

builder for '/nix/store/kgl4w97v1wigabysi9cib1qrn58dl6fm-qtile-0.16.0.drv' failed with exit code 1; last 10 log lines:
    /build/source/libqtile/utils.py:141: UnixCommandNotFound: No such file or directory: 'sensors'
      warnings.warn(err.strerror, warning)
  
  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  =========================== short test summary info ============================
  FAILED test/test_images.py::test_get_cairo_surface[/build/source/test/data/svg/audio-volume-muted.svg]
  ERROR test/test_manager.py::test_events[xephyr0-ManagerConfig] - AssertionErr...
  ERROR test/test_manager.py::test_adddelgroup[xephyr0-ManagerConfig] - Asserti...
  ERROR test/test_manager.py::test_xeyes[xephyr1-ManagerConfig] - AssertionErro...
  = 1 failed, 265 passed, 14 skipped, 87 deselected, 1 warning, 3 errors in 133.25s (0:02:13) =

Lassulus · 2020-07-25T20:42:58Z

this time I got:

builder for '/nix/store/bznzgdcz5ggz109w2pd0kdcn6dl9fsgv-qtile-0.16.0.drv' failed with exit code 1; last 10 log lines:
  Errors from xkbcomp are not fatal to the X server
  =============================== warnings summary ===============================
  test/widgets/test_misc.py::test_thermalsensor_regex_compatibility
    /build/source/libqtile/utils.py:141: UnixCommandNotFound: No such file or directory: 'sensors'
      warnings.warn(err.strerror, warning)
  
  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  =========================== short test summary info ============================
  ERROR test/test_manager.py::test_match[xephyr0-ManagerConfig] - AssertionErro...
  = 238 passed, 1 skipped, 130 deselected, 1 warning, 1 error in 110.37s (0:01:50) =
cannot build derivation '/nix/store/k7nhspbbwnv3ypfib3a4c5sjf3zmn0y2-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/k7nhspbbwnv3ypfib3a4c5sjf3zmn0y2-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/93837
1 package failed to build:
qtile

deliciouslytyped · 2020-07-26T17:17:59Z

Dev says " xcffib.ConnectionException: xcb connection errors because of socket, pipe and other stream errors." means the X server is crashing. I don't know why, but an intermediate workaround seems to be to use pytest-rerunfailures to rerun tests.
I don't know what the failure probability is, so I chose 5 retries arbitrarily.

Some bad statistics:
Assuming randomly distributed failures (which is probably wrong), if 20 out of 300 tests fail, we estimate a failure probability of 1/15. 5 runs of that should be low enough

Edit: It's notable that those are marked "ERROR" and actually failing tests are marked "FAILED".

…iting

deliciouslytyped · 2020-07-26T20:34:21Z

Looks like the svg errors are due to env vars being lost somewhere again;

$ GDK_PIXBUF_MODULE_FILE= python
Python 3.7.4 (default, Jul  8 2019, 18:31:06) 
[GCC 7.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import cairocffi.pixbuf as p
>>> p.decode_to_pixbuf(open("wat.svg", "rb").read())

(process:27392): GdkPixbuf-WARNING **: 22:28:18.267: Cannot open pixbuf loader module file '': No such file or directory

This likely means that your installation is broken.
Try running the command
  gdk-pixbuf-query-loaders > 
to make things work again for the time being.
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/nix/store/lyza33w1nam3y3h6qp8qm3habj3f6jbi-python3-3.7.4-env/lib/python3.7/site-packages/cairocffi/pixbuf.py", line 91, in decode_to_pixbuf
    handle_g_error(error, gdk_pixbuf.gdk_pixbuf_loader_close(loader, error))
  File "/nix/store/lyza33w1nam3y3h6qp8qm3habj3f6jbi-python3-3.7.4-env/lib/python3.7/site-packages/cairocffi/pixbuf.py", line 55, in handle_g_error
    raise ImageLoadingError(message)
cairocffi.pixbuf.ImageLoadingError: Pixbuf error: Unrecognized image file format
>>> 



$ python
Python 3.7.4 (default, Jul  8 2019, 18:31:06) 
[GCC 7.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import cairocffi.pixbuf as p
>>> p.decode_to_pixbuf(open("wat.svg", "rb").read())
(<cairocffi.pixbuf.Pixbuf object at 0x7f31ca4d7510>, 'svg')
>>>

doronbehar · 2020-09-11T13:12:43Z

pkgs/applications/window-managers/qtile/default.nix

+      src = ./0003-Restart-executable.patch;
+      out = "$out";
+      })
+    ./0004-Keep-env-in-test-process-spawner.patch #TODO upstream this


How about doing it? :)

doronbehar · 2020-09-11T13:14:10Z

pkgs/applications/window-managers/qtile/default.nix

+      --set GDK_PIXBUF_MODULE_FILE "$GDK_PIXBUF_MODULE_FILE" \
+      --set QTILE_WRAPPER '$0' \
+      --set QTILE_SAVED_PYTHONPATH '$PYTHONPATH' \
+      --set QTILE_SAVED_PATH '$PATH'


Haven't built it locally, but I think there's double wrapping here. If I'm correct, could you please use makeWrapperArgs?

doronbehar · 2020-09-11T13:15:14Z

pkgs/applications/window-managers/qtile/default.nix

-  buildInputs = [ glib libxcb cairo pango python37Packages.xcffib ];
+  buildInputs = [ glib libxcb cairo pango pypa.xcffib librsvg ]; 
+
+  pythonPath = with pypa; [ xcffib cairocffi-xcffib setuptools setuptools_scm ]; 


Is this used?

doronbehar · 2020-09-11T13:15:44Z

pkgs/applications/window-managers/qtile/default.nix

@@ -17,34 +26,60 @@ python37Packages.buildPythonApplication rec {
  };

  patches = [
-    ./0001-Substitution-vars-for-absolute-paths.patch
+    (substituteAll {


It'd be nice to have a comment above each patch explaining them.

deliciouslytyped · 2020-09-12T11:55:50Z

Just leaving a note here that I'm not sure when I will be working on this again, so if anyone is interested, feel free to take it up!
I'll leave a note if I pick it up again.

stale · 2021-07-21T02:12:10Z

I marked this as stale due to inactivity. → More info

ofborg bot added the 2.status: merge conflict label Jul 25, 2020

deliciouslytyped force-pushed the qtile-update branch from f2c2d63 to e0c9f64 Compare July 25, 2020 18:35

ofborg bot removed the 2.status: merge conflict label Jul 25, 2020

deliciouslytyped force-pushed the qtile-update branch from e0c9f64 to 52ac484 Compare July 25, 2020 18:43

ofborg bot requested a review from kamilchm July 25, 2020 18:43

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 25, 2020

deliciouslytyped force-pushed the qtile-update branch from 52ac484 to 04426c1 Compare July 25, 2020 19:29

deliciouslytyped force-pushed the qtile-update branch from 04426c1 to 43b92f8 Compare July 25, 2020 19:41

deliciouslytyped force-pushed the qtile-update branch from 43b92f8 to 4e742ad Compare July 26, 2020 17:45

qtile: disable failing tests, restore home variable instead of overwr…

0b4c420

…iting

deliciouslytyped force-pushed the qtile-update branch from 4e742ad to 0b4c420 Compare July 26, 2020 17:52

deliciouslytyped added 3 commits July 26, 2020 22:58

fix svg errors

a8e6484

qtile: fix tests, refactor

2f12d3b

fix svg again

4779dba

deliciouslytyped force-pushed the qtile-update branch from 8337a5f to 4779dba Compare July 28, 2020 15:28

doronbehar requested changes Sep 11, 2020

View reviewed changes

SuperSandro2000 added the 2.status: merge conflict label Jan 18, 2021

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021

wegank marked this pull request as draft March 20, 2024 15:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Qtile tests #93837

Enable Qtile tests #93837

deliciouslytyped commented Jul 25, 2020 •

edited

deliciouslytyped commented Jul 25, 2020

Lassulus commented Jul 25, 2020

Lassulus commented Jul 25, 2020

deliciouslytyped commented Jul 26, 2020 •

edited

deliciouslytyped commented Jul 26, 2020

doronbehar Sep 11, 2020

doronbehar Sep 11, 2020

doronbehar Sep 11, 2020

doronbehar Sep 11, 2020

deliciouslytyped commented Sep 12, 2020

stale bot commented Jul 21, 2021

Enable Qtile tests #93837

Are you sure you want to change the base?

Enable Qtile tests #93837

Conversation

deliciouslytyped commented Jul 25, 2020 • edited

deliciouslytyped commented Jul 25, 2020

Lassulus commented Jul 25, 2020

Lassulus commented Jul 25, 2020

deliciouslytyped commented Jul 26, 2020 • edited

deliciouslytyped commented Jul 26, 2020

doronbehar Sep 11, 2020

Choose a reason for hiding this comment

doronbehar Sep 11, 2020

Choose a reason for hiding this comment

doronbehar Sep 11, 2020

Choose a reason for hiding this comment

doronbehar Sep 11, 2020

Choose a reason for hiding this comment

deliciouslytyped commented Sep 12, 2020

stale bot commented Jul 21, 2021

deliciouslytyped commented Jul 25, 2020 •

edited

deliciouslytyped commented Jul 26, 2020 •

edited