Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kbounce: init 20.04.3 #93840

Merged
merged 24 commits into from Aug 27, 2020
Merged

kbounce: init 20.04.3 #93840

merged 24 commits into from Aug 27, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Jul 25, 2020 •
edited

Motivation for this change

new package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy freezeboy requested a review from ttuegel as a code owner July 25, 2020 19:14
@freezeboy freezeboy changed the title kbounce: init 20.03.3 kbounce: init 20.04.3 Jul 25, 2020
@freezeboy
Copy link
Contributor Author

@ttuegel Do you know how to deal with the 30 PRs I proposed ? they are all basically using the same principle

@Lassulus
Copy link
Member

can you squash the commits?

@freezeboy
Copy link
Contributor Author

Collecting the different kdeApps in this PR and reorganizing the inherit in top-level/all-applications to avoid future conflicts

@freezeboy freezeboy mentioned this pull request Aug 21, 2020
Merged
10 tasks
@peterhoeg
Copy link
Member

This should be merged after #95893 to avoid a rebuild.

ttuegel
ttuegel approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I wondered about the dependency of kalzium on avogadro.

pkgs/applications/kde/kalzium.nix
];
buildInputs = [
qtscript
#avogadro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dependency needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently I didn't succeed compiling kalzium with avogadro support (dont really know what it does in fact, just saw the reference in the CMakeLists.txt)

Do you want me to remove the reference ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's OK.

@peterhoeg peterhoeg changed the base branch from master to staging August 27, 2020 16:00
@peterhoeg
Copy link
Member

#95893 was merged to staging, so I changed the base here as well.

@ttuegel ttuegel merged commit 5b2a44f into NixOS:staging Aug 27, 2020
peterhoeg
peterhoeg reviewed Aug 28, 2020
View reviewed changes
pkgs/applications/kde/kigo.nix
name = "kigo";
meta = with lib; {
homepage = "https://kde.org/applications/en/games/org/kde.kigo";
description = "Kigo est une implémentation libre du jeu de Go";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freezeboy - any reason this is in French?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong copy paste I guess, I should start a new PR from staging ?

@freezeboy freezeboy mentioned this pull request Aug 28, 2020
Merged
10 tasks
@peterhoeg
Copy link
Member

peterhoeg commented Aug 28, 2020 via email

@freezeboy freezeboy deleted the add-kbounce branch August 28, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@peterhoeg peterhoeg peterhoeg left review comments

Assignees
No one assigned
Labels
6.topic: qt/kde 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freezeboy @Lassulus @peterhoeg @ttuegel