humioctl: init at 0.25.0 #93839
humioctl: init at 0.25.0 #93839
Conversation
|
@kalbasit Any chance I can get a +1 on this? 😄 |
maintainers/maintainer-list.nix
Outdated
| github = "lucperkins"; | ||
| githubId = 1523104; | ||
| name = "Luc Perkins"; | ||
| }; |
There was a problem hiding this comment.
This should be in a separate commit:
maintainers: add lucperkins
| let | ||
| version = "0.25.0"; | ||
| sha256 = "1x8354m410nf9g167v0i1c77s5w2by7smdlyjwl89ixgdjw04ay3"; | ||
| in buildGoModule { |
There was a problem hiding this comment.
Please inline these, there's no point to define these as local variables. You'll have to use rec in order to define and use the version in the same derivation FYI.
There was a problem hiding this comment.
I like having these at the top so that it's immediately clear which variables need to be updated for each release. Furthermore, I've come to see rec as an anti-pattern to be avoided when possible. I have, however, made the other suggested changes.
| pname = "humioctl"; | ||
| version = version; | ||
|
|
||
| goPackagePath = "github.com/humio/cli"; |
There was a problem hiding this comment.
| goPackagePath = "github.com/humio/cli"; |
This is not used by buildGoModule.
| sha256 = sha256; | ||
| }; | ||
|
|
||
| subPackages = ["."]; |
There was a problem hiding this comment.
| subPackages = ["."]; |
I don't believe that you need this, but I could be wrong.
|
/marvin opt-in |
|
@GrahamcOfBorg build humioctl |
Motivation for this change
This PR adds the CLI for Humio,
humioctl, to nixpkgs.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)