Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semantik: Init at 1.2.5 #95818

Merged
merged 4 commits into from Mar 21, 2021
Merged

semantik: Init at 1.2.5 #95818

merged 4 commits into from Mar 21, 2021

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

@Blub asked for this package on #nixos IRC

Things done

Patched the wscript and tested execution on release 1.2.5

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Blub
Copy link

Blub commented Aug 20, 2020

Different Blub, though :-)

SuperSandro2000
SuperSandro2000 reviewed Mar 21, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofborg eval

pkgs/applications/office/semantik/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit e36737f into NixOS:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SCOTT-HAMILTON @Blub @SuperSandro2000