Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia_x11: 450.57 -> 450.66 #95799

Merged
merged 1 commit into from Aug 19, 2020
Merged

nvidia_x11: 450.57 -> 450.66 #95799

merged 1 commit into from Aug 19, 2020

Conversation

Atemu
Copy link
Member

@Atemu Atemu commented Aug 19, 2020 •
edited

Motivation for this change

https://www.gamingonlinux.com/2020/08/nvidia-driver-45066-released-for-linux-includes-a-useful-vulkan-sync-fix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Atemu Atemu requested a review from eadwu August 19, 2020 12:31
@Atemu
Copy link
Member Author

Atemu commented Aug 19, 2020

Tested it briefly in GW2, no issues afaict.

eadwu
eadwu approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@eadwu eadwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and working fine on my end.

jonringer
jonringer approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
failures are broken on master branch

https://github.com/NixOS/nixpkgs/pull/95799
4 packages marked as broken and skipped:
linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_beta linuxPackages_hardkernel_latest.nvidia_x11 linuxPackages_hardkernel_latest.nvidia_x11_beta

5 packages failed to build:
haskellPackages.cuda linuxPackages-libre.nvidia_x11 linuxPackages_latest-libre.nvidia_x11 python27Packages.cupy python37Packages.tensorflowWithCuda

24 packages built:
bumblebee geekbench linuxPackages.nvidia_x11 linuxPackages_4_14.nvidia_x11 linuxPackages_4_19.nvidia_x11 linuxPackages_4_4.nvidia_x11 linuxPackages_4_9.nvidia_x11 linuxPackages_5_7.nvidia_x11 linuxPackages_hardened.nvidia_x11 linuxPackages_latest_hardened.nvidia_x11 linuxPackages_latest_xen_dom0.nvidia_x11 linuxPackages_latest_xen_dom0_hardened.nvidia_x11 linuxPackages_testing_bcachefs.nvidia_x11 linuxPackages_xen_dom0.nvidia_x11 linuxPackages_xen_dom0_hardened.nvidia_x11 linuxPackages_zen.nvidia_x11 nvtop primus psensor python27Packages.TheanoWithCuda python37Packages.TheanoWithCuda python37Packages.cupy python38Packages.TheanoWithCuda python38Packages.cupy

@jonringer jonringer merged commit 4f7cc3b into NixOS:master Aug 19, 2020
@Atemu Atemu deleted the update/nvidia branch August 20, 2020 03:26
@Atemu
Copy link
Member Author

Atemu commented Aug 20, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@eadwu eadwu eadwu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atemu @jonringer @eadwu