Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7dec299b89c1
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 259dcd17fff3
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Aug 19, 2020

  1. buildGoModule: remove modSha256

    zowoq committed Aug 19, 2020
    Copy the full SHA
    92a2c31 View commit details
  2. Copy the full SHA
    259dcd1 View commit details
Showing with 1 addition and 237 deletions.
  1. +1 −3 nixos/doc/manual/release-notes/rl-2009.xml
  2. +0 −5 pkgs/development/go-modules/generic/default.nix
  3. +0 −229 pkgs/development/go-modules/generic/old.nix
4 changes: 1 addition & 3 deletions nixos/doc/manual/release-notes/rl-2009.xml
Original file line number Diff line number Diff line change
@@ -202,9 +202,7 @@ GRANT ALL PRIVILEGES ON *.* TO 'mysql'@'localhost' WITH GRANT OPTION;
likekly to break with future versions of go. As a result
<literal>buildGoModule</literal> switched from
<literal>modSha256</literal> to the <literal>vendorSha256</literal>
attribute to pin fetched version data. <literal>buildGoModule</literal>
still accepts <literal>modSha256</literal> with a warning, but support will
be removed in the next release.
attribute to pin fetched version data.
</para>
</listitem>
<listitem>
5 changes: 0 additions & 5 deletions pkgs/development/go-modules/generic/default.nix
Original file line number Diff line number Diff line change
@@ -24,8 +24,6 @@
# This is useful if any dependency contain C files.
, runVend ? false

, modSha256 ? null

# We want parallel builds by default
, enableParallelBuilding ? true

@@ -257,8 +255,5 @@ let
});
in if disabled then
throw "${package.name} not supported for go ${go.meta.branch}"
else if modSha256 != null then
lib.warn "modSha256 is deprecated and will be removed in the next release (20.09), use vendorSha256 instead" (
import ./old.nix { inherit go cacert git lib removeReferencesTo stdenv; } args')
else
package
229 changes: 0 additions & 229 deletions pkgs/development/go-modules/generic/old.nix

This file was deleted.