Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psftools: init at 1.0.13 #95794

Merged
merged 1 commit into from Oct 17, 2020
Merged

psftools: init at 1.0.13 #95794

merged 1 commit into from Oct 17, 2020

Conversation

KAction
Copy link
Contributor

@KAction KAction commented Aug 19, 2020

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KAction
Copy link
Contributor Author

KAction commented Oct 7, 2020

Rebased on master, fixed meta

@KAction
Copy link
Contributor Author

KAction commented Oct 17, 2020

@ryantm Can you please merge this?

@ryantm
Copy link
Member

ryantm commented Oct 17, 2020

Result of nixpkgs-review pr 95794 1

1 package built:
- psftools

@ryantm ryantm merged commit 3312e1c into NixOS:master Oct 17, 2020
@KAction KAction deleted the psftools branch October 29, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 left review comments

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KAction @ryantm @OPNA2608