Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytorch-lightning: init at 0.8.5 #95827

Merged
merged 1 commit into from Aug 21, 2020
Merged

python3Packages.pytorch-lightning: init at 0.8.5 #95827

merged 1 commit into from Aug 21, 2020

Conversation

bcdarwin
Copy link
Member

Motivation for this change

Refresh of #77155 but without adding an expression for the test-tube dependency which is now optional except for testing, and we don't run the tests.

Added @tbenst as maintainer but happy to change it to or add myself.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [NA] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin bcdarwin requested a review from tbenst August 20, 2020 01:57
drewrisinger
drewrisinger suggested changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly formatting fixes.

Haven't tried building yet.

pkgs/development/python-modules/pytorch-lightning/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytorch-lightning/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytorch-lightning/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytorch-lightning/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytorch-lightning/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytorch-lightning/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

drewrisinger commented Aug 21, 2020 •
edited

Fixes #77155

@bcdarwin bcdarwin force-pushed the pytorch-lightning branch 2 times, most recently from a516027 to 6312274 Compare August 21, 2020 14:44
jonringer
jonringer approved these changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/95827
2 packages built:
python37Packages.pytorch-lightning python38Packages.pytorch-lightning

@jonringer jonringer merged commit 7ab4ee9 into NixOS:master Aug 21, 2020
@bcdarwin bcdarwin deleted the pytorch-lightning branch August 21, 2020 18:54
This was referenced Aug 21, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@tbenst tbenst Awaiting requested review from tbenst

@drewrisinger drewrisinger Awaiting requested review from drewrisinger

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @drewrisinger @jonringer